Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use named parameters in LedgerErrorKey #5208

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Use named parameters in LedgerErrorKey #5208

merged 1 commit into from
Jul 17, 2024

Conversation

dskloetd
Copy link
Contributor

Motivation

When a function or constructor has multiple parameters, we agreed to use named parameters.
The LedgerErrorKey constructor has 2 (optional) parameters which are positional parameters.

Changes

Use named parameters in the LedgerErrorKey constructor.

Tests

Updated.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review July 17, 2024 12:28
@dskloetd dskloetd requested a review from a team as a code owner July 17, 2024 12:28
@dskloetd dskloetd added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 3837d03 Jul 17, 2024
40 checks passed
@dskloetd dskloetd deleted the kloet/error-message branch July 17, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @mstrasinskis