Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bot: Update proposals candid bindings #5191

Merged
merged 1 commit into from
Jul 15, 2024
Merged

bot: Update proposals candid bindings #5191

merged 1 commit into from
Jul 15, 2024

Conversation

sa-github-api
Copy link
Collaborator

Motivation

We would like to render all the latest proposal types.
Even with no changes, just updating the reference is good practice.

Changes

  • Update the version of IC_COMMIT_FOR_PROPOSALS specified in dfx.json.
  • Updated the proposals candid files to the versions in that commit.
  • Updated the Rust code derived from .did files in the proposals payload rendering crate.

Tests

  • Please check the API updates for any breaking changes that affect our code.
  • Please check for new proposal types and add tests for them.

Breaking changes are:

  • New mandatory fields
    • Removing mandatory fields
    • Renaming fields
    • Changing the type of a field
    • Adding new variants

@sa-github-api sa-github-api requested a review from a team as a code owner July 15, 2024 03:35
@dskloetd dskloetd added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit ac1bc6e Jul 15, 2024
40 checks passed
@dskloetd dskloetd deleted the bot-proposals-update-1721014530 branch July 15, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

@mstrasinskis mstrasinskis Awaiting requested review from mstrasinskis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sa-github-api @dskloetd @gix-bot