-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token table ordering #5189
Merged
Merged
Token table ordering #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
reviewed
Jul 15, 2024
dskloetd
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, tokens table has a fixed list of tokens considered important on top ordered (ICP, ckBTC, ckETH, ckUSDC) followed by SNS tokens ordered by creation date. This ordering seems random for new people entering the ecosystem, and only takes into account user balances after a user takes action.
Suggested order:
a. First important token list in predefined order - ckBTC, ckETH, ckUSDC
b. Sns tokens ordered alphabetically
a. First important token list in predefined order - ckBTC, ckETH, ckUSDC
b. Sns tokens ordered alphabetically
Changes
compareTokensForTokensTable
merged comparator.Tests
Todos