Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace secondsToDuration with utils move to ic-js #3773

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Replace secondsToDuration with utils move to ic-js #3773

merged 3 commits into from
Nov 16, 2023

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Nov 16, 2023 •
edited
Loading

Motivation

secondsToDuration has been moved to @dfinity/utils therefore this PR replaces the usage of the function by the one in the library. It also remove the duplicate implementation within NNS dapp which becomes unused.

PRs

mstrasinskis
mstrasinskis approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@peterpeterparker peterpeterparker added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit b0642f2 Nov 16, 2023
47 checks passed
@peterpeterparker peterpeterparker deleted the feat/sconds-to-duration branch November 16, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @mstrasinskis