Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ic-js #3564

Closed
wants to merge 2 commits into from
Closed

Bump ic-js #3564

wants to merge 2 commits into from

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Oct 17, 2023 •
edited
Loading

Motivation

We want to be able to use retrieveBTCWithApproval on the ckBTC minter canister, which was added to ic-js in dfinity/ic-js#454.

Changes

  1. Updated frontend/package-lock.json by running npm run upgrade:next.
  2. In frontend/src/lib/utils/anonymize.utils.ts added isGenesis field to return value of anonymizeNeuronInfo and anonymizeFullNeuron to match the new types for Neuron and NeuronInfo, changed in GIX-1960: Upgrade nns-js ic commit ic-js#453.

Tests

Manually created an anonymized log by clicking 6 times and typing c.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review October 17, 2023 11:13
@dskloetd dskloetd requested a review from lmuntaner October 17, 2023 11:13
lmuntaner
lmuntaner approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you specify which changes were manual and which by the script?

@dskloetd
Copy link
Contributor Author

Could you specify which changes were manual and which by the script?

Like this?

@dskloetd
Copy link
Contributor Author

Replaced by #3566

@dskloetd dskloetd closed this Oct 17, 2023
@dskloetd dskloetd deleted the kloet/ckbtc-next branch May 27, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @lmuntaner