Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust #3356

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Update rust #3356

merged 3 commits into from
Sep 22, 2023

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Sep 22, 2023

Motivation

The rust updater tries to update to the wrong version. It gets the latest release from GitHub, however that does not correspond to the latest stable version. In fact, it currently matches an older release that presumably had a patch release.

Changes

  • Determine the latest stable version directly from the channel toml.

Tests

  • This now generates a PR to update Rust to 1.72.1 instead of 1.71.1.

Todos

  • Add entry to changelog (if necessary).

@bitdivine bitdivine marked this pull request as ready for review September 22, 2023 09:56
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bitdivine bitdivine added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 14ce43d Sep 22, 2023
@bitdivine bitdivine deleted the update-rust branch September 22, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants