Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to use
stakeNeuronIcrc1
added in dfinity/ic-js#418.Note: Manual changes were required to make nns-dapp build again.
Changes
npm run update:next
approve
field of a transaction inanonymizeSnsTransaction
.IcrcTransferError
. I usedIcrcTransferVariatError
because feat: icrc-2 support in ledger-js ic-js#416,IcrcTransferError.errorType
was of typeTransferError
andTransferError
is exported asIcrcTransferVariatError
here. But I have no idea if this makes sense or whatIcrcTransferVariatError
is. I guess it's a typo?Tests
Existing tests pass
Todos
not necessary