Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ic-js #3325

Closed
wants to merge 2 commits into from
Closed

Bump ic-js #3325

wants to merge 2 commits into from

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Sep 18, 2023

Motivation

We want to use stakeNeuronIcrc1 added in dfinity/ic-js#418.

Note: Manual changes were required to make nns-dapp build again.

Changes

  1. npm run update:next
  2. Anonimize the approve field of a transaction in anonymizeSnsTransaction.
  3. Provide a type parameter to IcrcTransferError. I used IcrcTransferVariatError because feat: icrc-2 support in ledger-js ic-js#416, IcrcTransferError.errorType was of type TransferError and TransferError is exported as IcrcTransferVariatError here. But I have no idea if this makes sense or what IcrcTransferVariatError is. I guess it's a typo?

Tests

Existing tests pass

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd closed this Sep 18, 2023
@dskloetd dskloetd deleted the kloet/icrc-next branch September 18, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant