-
Notifications
You must be signed in to change notification settings - Fork 43
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use QR code placeholder icon on ckBTC wallet page (#4176)
# Motivation We want to be able to render the wallet pages when the user is not signed in. On the ckBTC wallet page we show a QR code with the BTC deposit address. When the user is not signed in, there is no deposit address so we want to show a placeholder icon instead. <img width="788" alt="Screenshot 2024-01-11 at 14 57 09" src="https://github.com/dfinity/nns-dapp/assets/122978264/1b0f25b3-ad5f-40c0-b473-f447f5d71226"> <img width="418" alt="image" src="https://github.com/dfinity/nns-dapp/assets/122978264/e397af9b-1e4a-43dc-9c73-0c3523af72b2"> # Changes 1. Remove the white background for the QR code if the user is not signed in. 2. Show the QR code icon instead. # Tests Existing tests updated. # Todos - [ ] Add entry to changelog (if necessary). not user visible yet
- Loading branch information
Showing
3 changed files
with
27 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters