Skip to content

Commit

Permalink
Upgrade gix components next 2024 07 16 (#5203)
Browse files Browse the repository at this point in the history
# Motivation

Currently, nns-dapp icons are sourced from different libraries,
resulting in inconsistencies in style and line thickness. This update
standardises most of the icons to ensure they match the overall design
and maintain a consistent line thickness.

# Changes

- Bump gix-components to have latest icons.
- Use a custom `strokeWidth` for sorting icons to improve their
visibility.
- Upgrade e2e screenshots because of new icons.

# Tests

Demo:
https://qsgjb-riaaa-aaaaa-aaaga-cai.mstr-ingress.devenv.dfinity.network

- Tested manually.

# Todos

- [ ] Add entry to changelog (if necessary).

---------

Co-authored-by: gix-bot <[email protected]>
  • Loading branch information
mstrasinskis and gix-bot authored Jul 17, 2024
1 parent 099ec7f commit 8f237ac
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG-Nns-Dapp-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ proposal is successful, the changes it released will be moved from this file to

* Reduce the frequency of checking if SNS neurons need to be refreshed.
* New token table order.
* Update nns-dapp icons for consistent style and line thickness.

#### Deprecated

Expand Down
13 changes: 7 additions & 6 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/src/lib/components/ui/ResponsiveTable.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
>{column.title}{#if nonNullish(column.comparator) && order[0]?.columnId === column.id}
<span class="order-arrow">
<span class="arrow-icon" class:reversed={order[0].reversed}>
<IconSouth size="8" />
<IconSouth size="8" strokeWidth={2} />
</span>
</span>
{/if}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
>{$i18n.responsive_table.tap_to_reverse}<span
data-tid="arrow"
class="arrow-icon"
class:reversed={order[0].reversed}><IconSouth size="16" /></span
class:reversed={order[0].reversed}
><IconSouth size="16" strokeWidth={2} /></span
></span
>{/if}</button
>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 8f237ac

Please sign in to comment.