Enable ENABLE_NEURON_VISIBILITY (#5708)

# Motivation

We want to release neurons visibility on mainnet.

# Changes

1. Enabled `ENABLE_NEURON_VISIBILITY` in `dfx.json`.
2. Ran `./scripts/nns-dapp/test-config --update`.

# Tests

1. Updated e2e screenshots.

# Todos

- [x] Add entry to changelog (if necessary).

CHANGELOG-Nns-Dapp-unreleased.md

@@ -18,6 +18,7 @@ proposal is successful, the changes it released will be moved from this file to
 * A link to the imported tokens documentation page.
 * Refresh NNS neurons from neuron details page if needed, instead of from the nns-dapp canister.
 * Inform the user in the staking modal that the minimum dissolve delay for NNS neurons is 7 days.
+* Support public/private neuron visibility.
 
 #### Changed
 

dfx.json

@@ -388,7 +388,7 @@
           "ENABLE_CKTESTBTC": false,
           "ENABLE_IMPORT_TOKEN": true,
           "DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING": false,
-          "ENABLE_NEURON_VISIBILITY": false
+          "ENABLE_NEURON_VISIBILITY": true
         }
       }
     },

scripts/nns-dapp/test-config-assets/app/arg.did

@@ -10,7 +10,7 @@
     record{ 0="CKUSDC_LEDGER_CANISTER_ID"; 1="xevnm-gaaaa-aaaar-qafnq-cai" };
     record{ 0="CYCLES_MINTING_CANISTER_ID"; 1="rkp4c-7iaaa-aaaaa-aaaca-cai" };
     record{ 0="DFX_NETWORK"; 1="app" };
-    record{ 0="FEATURE_FLAGS"; 1="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_IMPORT_TOKEN\":true,\"ENABLE_NEURON_VISIBILITY\":false}" };
+    record{ 0="FEATURE_FLAGS"; 1="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_IMPORT_TOKEN\":true,\"ENABLE_NEURON_VISIBILITY\":true}" };
     record{ 0="FETCH_ROOT_KEY"; 1="false" };
     record{ 0="GOVERNANCE_CANISTER_ID"; 1="rrkah-fqaaa-aaaaa-aaaaq-cai" };
     record{ 0="HOST"; 1="https://icp-api.io" };

scripts/nns-dapp/test-config-assets/app/env

@@ -7,7 +7,7 @@ VITE_LEDGER_CANISTER_ID=ryjl3-tyaaa-aaaaa-aaaba-cai
 VITE_INDEX_CANISTER_ID=qhbym-qaaaa-aaaaa-aaafq-cai
 VITE_OWN_CANISTER_ID=xnjld-hqaaa-aaaal-qb56q-cai
 VITE_FETCH_ROOT_KEY=false
-VITE_FEATURE_FLAGS="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_IMPORT_TOKEN\":true,\"ENABLE_NEURON_VISIBILITY\":false}"
+VITE_FEATURE_FLAGS="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_IMPORT_TOKEN\":true,\"ENABLE_NEURON_VISIBILITY\":true}"
 VITE_HOST=https://icp-api.io
 VITE_IDENTITY_SERVICE_URL=https://identity.internetcomputer.org/
 VITE_AGGREGATOR_CANISTER_URL=https://otgyv-wyaaa-aaaak-qcgba-cai.icp0.io

scripts/nns-dapp/test-config-assets/mainnet/arg.did

@@ -10,7 +10,7 @@
     record{ 0="CKUSDC_LEDGER_CANISTER_ID"; 1="xevnm-gaaaa-aaaar-qafnq-cai" };
     record{ 0="CYCLES_MINTING_CANISTER_ID"; 1="rkp4c-7iaaa-aaaaa-aaaca-cai" };
     record{ 0="DFX_NETWORK"; 1="mainnet" };
-    record{ 0="FEATURE_FLAGS"; 1="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_IMPORT_TOKEN\":true,\"ENABLE_NEURON_VISIBILITY\":false}" };
+    record{ 0="FEATURE_FLAGS"; 1="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_IMPORT_TOKEN\":true,\"ENABLE_NEURON_VISIBILITY\":true}" };
     record{ 0="FETCH_ROOT_KEY"; 1="false" };
     record{ 0="GOVERNANCE_CANISTER_ID"; 1="rrkah-fqaaa-aaaaa-aaaaq-cai" };
     record{ 0="HOST"; 1="https://icp-api.io" };

scripts/nns-dapp/test-config-assets/mainnet/env

@@ -7,7 +7,7 @@ VITE_LEDGER_CANISTER_ID=ryjl3-tyaaa-aaaaa-aaaba-cai
 VITE_INDEX_CANISTER_ID=qhbym-qaaaa-aaaaa-aaafq-cai
 VITE_OWN_CANISTER_ID=qoctq-giaaa-aaaaa-aaaea-cai
 VITE_FETCH_ROOT_KEY=false
-VITE_FEATURE_FLAGS="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_IMPORT_TOKEN\":true,\"ENABLE_NEURON_VISIBILITY\":false}"
+VITE_FEATURE_FLAGS="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_IMPORT_TOKEN\":true,\"ENABLE_NEURON_VISIBILITY\":true}"
 VITE_HOST=https://icp-api.io
 VITE_IDENTITY_SERVICE_URL=https://identity.internetcomputer.org/
 VITE_AGGREGATOR_CANISTER_URL=https://3r4gx-wqaaa-aaaaq-aaaia-cai.icp0.io