Skip to content

Commit

Permalink
NNS1-3485: updates the copy on the Reporting page (#5993)
Browse files Browse the repository at this point in the history
# Motivation

Refine the wording for the labels on the Reporting page.

# Changes

- Changed labels
- Added copy for the busy screen.

# Tests

- Updated tests

# Todos

- [ ] Add entry to changelog (if necessary).
Not necessary
  • Loading branch information
yhabib authored Dec 12, 2024
1 parent 56ccfb4 commit 7d63ce6
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@
const exportNeurons = async () => {
try {
loading = true;
startBusy({ initiator: "reporting-neurons" });
startBusy({
initiator: "reporting-neurons",
labelKey: "reporting.busy_screen",
});
// we are logged in to be able to interact with the button
const signIdentity = await getAuthenticatedIdentity();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@
const exportIcpTransactions = async () => {
try {
loading = true;
startBusy({ initiator: "reporting-transactions" });
startBusy({
initiator: "reporting-transactions",
labelKey: "reporting.busy_screen",
});
// we are logged in to be able to interact with the button
const signIdentity = identity as SignIdentity;
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/lib/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,13 @@
"neurons": "There was an error exporting the neurons. Please try again."
},
"reporting": {
"neurons_title": "Neurons Portfolio",
"neurons_title": "NNS Neurons Portfolio",
"neurons_description": "Download a detailed CSV report of your neuron portfolio, which includes the stake, maturity, and neuron account ID for manual tracking and analysis.",
"neurons_download": "Export Neurons Portfolio",
"transactions_title": "ICP Transactions",
"transactions_description": "Download a detailed CSV report of your token transaction history, including both regular token accounts and neurons that will show neuron staking and minting transactions for manual tracking and analysis.",
"transactions_download": "Export Transactions"
"transactions_download": "Export Transactions",
"busy_screen": "Generating report..."
},
"auth": {
"login": "Sign in with Internet Identity",
Expand Down
1 change: 1 addition & 0 deletions frontend/src/lib/types/i18n.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ interface I18nReporting {
transactions_title: string;
transactions_description: string;
transactions_download: string;
busy_screen: string;
}

interface I18nAuth {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ describe("ReportingNeuronsButton", () => {
expect(get(busyStore)).toEqual([
{
initiator: "reporting-neurons",
text: undefined,
text: "Generating report...",
},
]);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ describe("ReportingTransactionsButton", () => {
expect(get(busyStore)).toEqual([
{
initiator: "reporting-transactions",
text: undefined,
text: "Generating report...",
},
]);

Expand Down

0 comments on commit 7d63ce6

Please sign in to comment.