Skip to content

Commit

Permalink
Fix release-sop test (#3416)
Browse files Browse the repository at this point in the history
# Motivation

There is a `release-sop` tests what happens when HTML is found.
But the mocking behavior for the test didn't cause that step to fail
with non-zero exit code.

# Changes

1. Fix the behavior of `no_html_in_templates` to return 1 instead of 0.
2. Update the expected output with `scripts/nns-dapp/release-sop.test
--update`

# Tests

Change is test only.

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary
  • Loading branch information
dskloetd authored Sep 29, 2023
1 parent 28c9f55 commit 2894133
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions scripts/nns-dapp/release-sop-test-html-in-template.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"command": "no_html_in_templates",
"stdout": "Found @html",
"stderr": "",
"exitCode": 0
"exitCode": 1
}
],
"expectedOutput": [
Expand Down Expand Up @@ -108,14 +108,7 @@
"Expected npm audit: found 0 vulnerabilities",
"Security test: cargo audit: RUSTSEC-2020-0071,RUSTSEC-2020-0159",
"Expected cargo audit: RUSTSEC-2020-0071,RUSTSEC-2020-0159",
"Security test: no HTML in templates: Found @html",
"👇 Press enter to run the following command:",
"",
"scripts/nns-dapp/download-ci-wasm --commit tags/release-candidate --dir /home/runner/work/nns-dapp/release/ci --wasm-filename nns-dapp.wasm.gz",
"",
"scripts/nns-dapp/download-ci-wasm --commit tags/release-candidate --dir /home/runner/work/nns-dapp/release/ci --wasm-filename nns-dapp.wasm.gz: Done",
"No mock behavior for: scripts/nns-dapp/get-hash-from-ci-log --commit tags/release-candidate",
"CI NNS-dapp WASM hash: Failed"
"Security test: no HTML in templates: Failed"
],
"expectedExitCode": 1
}

0 comments on commit 2894133

Please sign in to comment.