feat: add prim deadline for receiver-side best-effort messages
#4795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
changed the title
prim deadline for receiver side best-effort messagesprim deadline for receiver-side best-effort messages
ggreif
commented
Dec 4, 2024
ggreif
force-pushed
the
gabor/deadline
branch
from
3b0e1b1 to
137c275
Compare
|
@oggy-dfin Is the system interface API |
* Update readme * Misc * Unabbreviate 'OO' * Try improving wording for OO line * Update wording * Adjust headers for consistency
ggreif
force-pushed
the
gabor/deadline
branch
from
567ba8f to
03a2000
Compare
ggreif
force-pushed
the
gabor/deadline
branch
from
ab40620 to
ea2f85f
Compare
ggreif
commented
Dec 5, 2024
| @@ -26,10 +26,10 @@ | |||
| "homepage": "", | |||
| "owner": "luc-blaeser", | |||
| "repo": "ic", | |||
| "rev": "33075cd385ea2ec4170f522406b1ff8f507fa744", | |||
| "sha256": "0swx7r78wjybx7fkfqsn9p3lqxmszgg24q4hrnxmscvyhb22hqia", | |||
| "rev": "bebe89514a6abd26e940b295323823169911a965", | |||
There was a problem hiding this comment.
enables the ic0.msg_deadline in drun
crusso
previously approved these changes
Dec 5, 2024
|
Might be worth testing some code in playground (uploading wasm) just to make sure its enabled on mainnet. |
|
It wasn't clear from the interface spec PR if this signed or unsigned, but seems to be using u64 in ic source code... |
https://play.motoko.org/?tag=661790008 has a deployed |
crusso
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf.
ic0.msg_deadlinein dfinity/portal#3764Adds
prim "deadline"and access to it viafunc replyDeadlineinmo:prim.All mainnet subnets are providing the system interface API, so this is safe to deploy.
Feature flag for
drunisEnabled.motoko-basesupport will be merged in short order.