Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for an IC Canisters Library #574

Closed
wants to merge 1 commit into from
Closed

Conversation

kentosugama
Copy link
Contributor

@kentosugama kentosugama commented Jul 6, 2023

Just seeing what this would look like before (potentially) creating a separate repo and a library for these definitions.

Some considerations:

  • To ensure backwards compatibility, it might be good to have these in a separate library from base (that could be published on mops) that would not have the same guarantee
  • Should we also provide wrappers to make it easier to make these calls?
  • These bindings are generated using didc

@kentosugama kentosugama self-assigned this Jul 6, 2023
@chenyan-dfinity
Copy link
Contributor

You may be using an out-dated didc. The latest one converts vec nat8 to Blob.

Another option is that:

import service "ic:canister_id"

automatically fetches the did file from metadata and generate the Motoko binding in the dfx build process. Then there is no need to have a library like this.

@ggreif
Copy link
Contributor

ggreif commented Jul 7, 2023

You may be using an out-dated didc. The latest one converts vec nat8 to Blob.

Another option is that:

import service "ic:canister_id"

automatically fetches the did file from metadata and generate the Motoko binding in the dfx build process. Then there is no need to have a library like this.

What about the management canister? I doubt you can fetch it this way.

@nomeata
Copy link
Contributor

nomeata commented Jul 7, 2023

What about the management canister? I doubt you can fetch it this way.

Maybe it should :-)

@kentosugama
Copy link
Contributor Author

Oh! I didn't know about that feature. Yes maybe this library is not needed then.

@kentosugama
Copy link
Contributor Author

kentosugama commented Aug 25, 2023

dfinity/sdk#3329

Working on having this in dfx.

EDIT: Done

@kentosugama kentosugama closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants