Adding toBytes and fromBytes to Nat32 #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We probably want to indicate the endianness in these functions, i.e. Also, the |
rossberg
reviewed
Jun 18, 2021
Comment on lines
+149
to
+152
| [ Prim.natToNat8(Prim.nat32ToNat((x >> 24) & (255))), | ||
| Prim.natToNat8(Prim.nat32ToNat((x >> 16) & (255))), | ||
| Prim.natToNat8(Prim.nat32ToNat((x >> 8) & (255))), | ||
| Prim.natToNat8(Prim.nat32ToNat((x & 255))) ]; |
There was a problem hiding this comment.
Nit:
Suggested change
| [ Prim.natToNat8(Prim.nat32ToNat((x >> 24) & (255))), | |
| Prim.natToNat8(Prim.nat32ToNat((x >> 16) & (255))), | |
| Prim.natToNat8(Prim.nat32ToNat((x >> 8) & (255))), | |
| Prim.natToNat8(Prim.nat32ToNat((x & 255))) ]; | |
| [ Prim.natToNat8(Prim.nat32ToNat(x >> 24 & 255)), | |
| Prim.natToNat8(Prim.nat32ToNat(x >> 16 & 255)), | |
| Prim.natToNat8(Prim.nat32ToNat(x >> 8 & 255)), | |
| Prim.natToNat8(Prim.nat32ToNat(x & 255)) ]; |
Comment on lines
+157
to
+160
| (Prim.natToNat32(Prim.nat8ToNat(x[0])) << 24) + | ||
| (Prim.natToNat32(Prim.nat8ToNat(x[1])) << 16) + | ||
| (Prim.natToNat32(Prim.nat8ToNat(x[2])) << 8) + | ||
| (Prim.natToNat32(Prim.nat8ToNat(x[3]))); |
There was a problem hiding this comment.
Suggested change
| (Prim.natToNat32(Prim.nat8ToNat(x[0])) << 24) + | |
| (Prim.natToNat32(Prim.nat8ToNat(x[1])) << 16) + | |
| (Prim.natToNat32(Prim.nat8ToNat(x[2])) << 8) + | |
| (Prim.natToNat32(Prim.nat8ToNat(x[3]))); | |
| Prim.natToNat32(Prim.nat8ToNat(x[0])) << 24 + | |
| Prim.natToNat32(Prim.nat8ToNat(x[1])) << 16 + | |
| Prim.natToNat32(Prim.nat8ToNat(x[2])) << 8 + | |
| Prim.natToNat32(Prim.nat8ToNat(x[3])); |
rossberg
reviewed
Jun 18, 2021
| @@ -2,6 +2,7 @@ | |||
| /// | |||
| /// Most operations are available as built-in operators (e.g. `1 + 1`). | |||
| import Nat "Nat"; | |||
| import Nat8 "Nat8"; | |||
There was a problem hiding this comment.
Is this module actually used?
|
still ok? |
ggreif
force-pushed
the
master
branch
2 times, most recently
from
d52aecd to
08507fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how to go about testing, but I tried to add tests as well. This same pattern can be followed for the hard edged NatXz. The Nat to bytes will need a bit more finesse than I have at the moment.