Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication with (older) identities that have devices without a (valid) credential id. #2760

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Dec 27, 2024

Fix authentication when (older) identities have devices without a (valid) credential id.

Changes

  • Reimplement old behavior from previous release where devices without a (valid) credential id are filtered out.
  • Improve guarantees during build time by moving credential id checks into convertToCredentialData method itself.

Added Tests

  • Check if devices are ignored with missing credential id
  • Check if devices are ignored with invalid credential id

🟡 Some screens were changed

@sea-snake sea-snake requested a review from lmuntaner December 27, 2024 11:25
@sea-snake sea-snake changed the title Fix authentication with (older) identities have devices without a credential id. Fix authentication with (older) identities that have devices without a credential id. Dec 27, 2024
@sea-snake sea-snake changed the title Fix authentication with (older) identities that have devices without a credential id. Fix authentication with (older) identities that have devices without a (valid) credential id. Dec 27, 2024
@lmuntaner
Copy link
Collaborator

Already approving, but please check my comment about renaming instead of creating another function.

@sea-snake sea-snake added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit 1e6cf69 Dec 30, 2024
68 checks passed
@sea-snake sea-snake deleted the sea-snake/fix-authentication-when-identities-have-devices-without-credential-id branch December 30, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants