UI Page to add current device to the current origin #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Page:
|
|
@LXIF @sea-snake please review |
lmuntaner
force-pushed
the
lm-page-replace-device-domain
branch
from
7133f76 to
1cdb051
Compare
lmuntaner
changed the title
sea-snake
requested changes
Dec 20, 2024
sea-snake
reviewed
Dec 20, 2024
| "title": "Add Current Device", | ||
| "paragraph": "Please add the current device to your identity to improve the user experience with Internet Identity.", | ||
| "skip": "Skip", | ||
| "replace_origin": "Add", |
sea-snake
reviewed
Dec 20, 2024
sea-snake
reviewed
Dec 20, 2024
sea-snake
approved these changes
Dec 20, 2024
Co-authored-by: sea-snake <[email protected]>
Co-authored-by: sea-snake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the migration plan for Domains Compatibility, we want to offer the user the possibility to add the current device to the current origin.
This is needed to avoid having a bad UX when the user logs in and the initial RP ID selected by the algorithm is incorrect and the user needs to try again. For example, the user has a device registered in the current domain, but is currently on another device.
Changes
addCurrentDevicewith its templates and pages.Tests
🟢 Some screens were added
🟡 Some screens were changed