Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nice UX when passkey is not found in that RP ID #2754

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Dec 18, 2024

Motivation

The algorithm to choose RP ID is not bulletproof. For those scenarios that the user needs to retry, we want to guide the user a bit.

In this PR, the UX is improved by showing an info toast encouraging the user to try again.

Changes

  • Add new return type PossiblyWrongRPID to the login and fromWebauthnCredentials methods.
  • Manage the new return type and show a toast info if so.

Tests

  • Tested in beta domains. See screen video.
  • Change current test for the scenario that has been changed.

🟡 Some screens were changed

@lmuntaner
Copy link
Collaborator Author

UX:

Screen.Recording.2024-12-18.at.12.50.52.mov

New toast:

Screenshot 2024-12-18 at 11 57 57

@lmuntaner lmuntaner requested review from sea-snake and LXIF December 18, 2024 12:09
@lmuntaner
Copy link
Collaborator Author

@LXIF @sea-snake please review

@lmuntaner lmuntaner marked this pull request as ready for review December 18, 2024 12:10
Copy link
Contributor

@LXIF LXIF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM technically, though admittedly wording is confusing - users may not know we have multiple domains and that passkeys are separated by domain.

@lmuntaner
Copy link
Collaborator Author

LGTM technically, though admittedly wording is confusing - users may not know we have multiple domains and that passkeys are separated by domain.

I agree. Thankfully, this is an edge case that I hope not many people will encounter.

I'm also open to other wordings, but this was the best I could think of. We can always change before enabling the flag in mainnet.

@lmuntaner lmuntaner added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 84a0cab Dec 18, 2024
68 checks passed
@lmuntaner lmuntaner deleted the lm-nice-ux-retry-different-ui branch December 18, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants