Use dynamic RP ID #2746
Merged
Use dynamic RP ID #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-snake
reviewed
Dec 12, 2024
|
@sea-snake ready for another review |
sea-snake
approved these changes
Dec 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support users registered in different II domains.
After this PR, if the
related_originsis set (which they are in beta) and flagDOMAIN_COMPATIBILITYis enabled, users can register in any domain and login in any other domain with the same passkey.Changes
Tests
https://beta.identity.ic0.app/andhttps://beta.identity.internetcomputer.org/.🟡 Some screens were changed