Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper to check browser version #2743

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Add helper to check browser version #2743

merged 2 commits into from
Dec 11, 2024
+241 −0

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Dec 11, 2024 •
edited by github-actions bot
Loading

Motivation

I want to check for support for Related Origins Requests.

Changes

  • checkRequiredBrowserVersion to check browser versions.
  • supportsWebauthRoR that uses checkRequiredBrowserVersion to check whether a user agent supports Related Origins Requests.

Tests

  • Test both helpers.
🟡 Some screens were changed

@lmuntaner lmuntaner requested review from sea-snake and LXIF December 11, 2024 09:25
@lmuntaner
Copy link
Collaborator Author

@LXIF @sea-snake please review

@lmuntaner lmuntaner marked this pull request as ready for review December 11, 2024 09:36
LXIF
LXIF approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@LXIF LXIF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmuntaner lmuntaner added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit d6d758f Dec 11, 2024
67 checks passed
@lmuntaner lmuntaner deleted the lm-add-helper-browser-support branch December 11, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LXIF LXIF LXIF approved these changes

@sea-snake sea-snake Awaiting requested review from sea-snake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @LXIF