Share CredentialData param type of fromCredentials #2742
Merged
+75
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sea-snake @LXIF please review |
sea-snake
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To support domain compatibility, we need to use the helper to find the RP ID.
The idea is to use the helper
findWebAuthnRpIdwithinfromCredentialsfromMultiWebAuthnIdentity.Therefore, I reused the type expected there in all the chain that uses it.
At the moment, we could have used
DeviceData, but API v2 doesn't use this type. Therefore, I didn't want to rely on this and reuse the custom type that holds the necessary fields for the logic.Changes
CredentialDatato its own module and add a converter to be used.CredentialDatainfindWebAuthnRpIdandfromWebauthnCredentials.Tests
findWebAuthnRpIdto use the new parameter type.🟡 Some screens were changed