Ignore messages from own origin #2363
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, II prints a warning to the console (or in case of the VC-flow even shows a toast) when it receives an unexpected message. Messages might get sent from browser extension (i.e. the MetaMask extension does that), which can be recognized by having the same origin as II itself. Since II does not send messages to itself, we can safely ignore all of these messages (and the messages do not warrant an `error`).
lmuntaner
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, II prints a warning to the console (or in case of the VC-flow even shows a toast) when it receives an unexpected message. Messages might get sent from browser extension (i.e. the MetaMask extension does that), which can be recognized by having the same origin as II itself. Since II does not send messages to itself, we can safely ignore all of these messages (and the messages do not warrant an
error).🟡 Some screens were changed