Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless Result aliases #2148

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Remove useless Result aliases #2148

merged 2 commits into from
Dec 19, 2023

Conversation

frederikrothenberger
Copy link
Contributor

@frederikrothenberger frederikrothenberger commented Dec 18, 2023 •
edited by github-actions bot
Loading

This PR removes a few types that could be replaced by std::Result.

Remove useless Result aliases
0870902 
This PR removes a few types that could be replaced by
`std::Result`.
przydatek
przydatek approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also vc_spec.md, otherwise LGTM. Thanks!

demos/vc_issuer/tests/issue_credential.rs Outdated Show resolved Hide resolved
@frederikrothenberger frederikrothenberger added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit 2e08c00 Dec 19, 2023
57 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/refactor-custom-results branch December 19, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przydatek przydatek przydatek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikrothenberger @przydatek