Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with local URLs #2147

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

frederikrothenberger
Copy link
Contributor

@frederikrothenberger frederikrothenberger commented Dec 18, 2023

The recent refactoring with multiple JS bundles has lead to II breaking in Chrome, when the canister id is supplied as an URL parameter.
There is no easy or nice solution, so for now we just advise developers to use a different URL scheme when using anything but Safari.

The recent refactoring with multiple JS bundles has lead
to II breaking in Chrome, when the canister id is supplied as
an URL parameter.
There is no easy or nice solution, so for now we just advise
developers to use a different URL scheme when using anything but
Safari.
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments. Thanks!

README.md Outdated Show resolved Hide resolved
demos/using-dev-build/README.md Outdated Show resolved Hide resolved
@frederikrothenberger frederikrothenberger added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit e58865d Dec 18, 2023
57 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/update-readme branch December 18, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants