Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approve information Sharing CSS #2138

Merged
merged 14 commits into from
Dec 15, 2023
Merged

Approve information Sharing CSS #2138

merged 14 commits into from
Dec 15, 2023

Conversation

meodai
Copy link
Contributor

@meodai meodai commented Dec 14, 2023 •
edited by github-actions bot
Loading

Screenshot 2023-12-14 at 18 22 29

  • Replicate the VC screen as well as possible using existing components
  • Add the concept of ".t-formatted" for reformatted HTML text. In this case Markdown
  • Slightly modify the dapps Explorer component to be useful for origins
  • Add a .c-card--consent class
🟡 Some screens were changed

@meodai
Copy link
Contributor Author

meodai commented Dec 14, 2023

@frederikrothenberger I don't understand why the usePin workflow is failing :(

@frederikrothenberger
Copy link
Contributor

@frederikrothenberger I don't understand why the usePin workflow is failing :(

It seems to have been a viewport issue on mobile sized chrome. I have pushed a fix to this PR.

@meodai meodai enabled auto-merge December 15, 2023 10:46
frederikrothenberger
frederikrothenberger approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise looks good to me.

Disclaimer, I did not look at the CSS.

src/frontend/src/flows/verifiableCredentials/allowCredentials.ts Outdated Show resolved Hide resolved
src/frontend/src/flows/verifiableCredentials/allowCredentials.ts Outdated Show resolved Hide resolved
@meodai meodai added this pull request to the merge queue Dec 15, 2023
@frederikrothenberger frederikrothenberger removed this pull request from the merge queue due to a manual request Dec 15, 2023
@frederikrothenberger frederikrothenberger added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 2958671 Dec 15, 2023
57 checks passed
@frederikrothenberger frederikrothenberger deleted the da-vcdesign branch December 15, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meodai @frederikrothenberger