Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy CANISTER.localhost #2102

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Proxy CANISTER.localhost #2102

merged 1 commit into from
Dec 5, 2023

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Dec 4, 2023

This changes the local setup -- in particular, the replicaForwardPlugin -- to allow redirecting to canister by names.

Until now, NAME.localhost had to be added manually as a host, alongside with a canister name.

With these changes, the replica forward plugin will try find a local canister foo to proxy to for any foo.localhost:<vite port> request.

This changes the local setup -- in particular, the
`replicaForwardPlugin` -- to allow redirecting to canister by names.

Until now, `NAME.localhost` had to be added manually as a host,
alongside with a canister name.

With these changes, the replica forward plugin will try find a local canister
`foo` to proxy to for any `foo.localhost:<vite port>` request.
Copy link
Contributor

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nmattia nmattia added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 01cef4a Dec 5, 2023
53 checks passed
@nmattia nmattia deleted the nm-redirect-all branch December 5, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants