Add markdown support for consent message #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for rendering consent messages as markdown. We use [`marked`](https://www.npmjs.com/package/marked) for rendering the markdown to HTML, and then sanitize the HTML with [`DOMPurify`](https://www.npmjs.com/package/dompurify). The consent message is rendered async and the original message (raw markdown) is shown until the markdown was rendered (in practice, instantaneous).
nmattia
commented
Dec 4, 2023
src/frontend/src/flows/verifiableCredentials/allowCredentials.ts
Outdated
Show resolved
Hide resolved
src/frontend/src/flows/verifiableCredentials/allowCredentials.ts
Outdated
Show resolved
Hide resolved
src/frontend/src/flows/verifiableCredentials/allowCredentials.ts
Outdated
Show resolved
Hide resolved
nmattia
force-pushed
the
nm-md-consent
branch
from
4a55488 to
e0f7eac
Compare
nmattia
added a commit
that referenced
this pull request
Dec 8, 2023
* Add markdown support for consent message This adds support for rendering consent messages as markdown. We use [`marked`](https://www.npmjs.com/package/marked) for rendering the markdown to HTML, and then sanitize the HTML with [`DOMPurify`](https://www.npmjs.com/package/dompurify). The consent message is rendered async and the original message (raw markdown) is shown until the markdown was rendered (in practice, instantaneous). * Use NNS dapp markdown helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for rendering consent messages as markdown.
We use
markedfor rendering the markdown to HTML, and then sanitize the HTML withDOMPurify. The consent message is rendered async and the original message (raw markdown) is shown until the markdown was rendered (in practice, instantaneous).🟡 Some screens were changed