Move asset certification header code to asset_util #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves code from `http.rs` into the new `asset_util` crate. This PR is step **2** of 4: 1. move code from `assets.rs` to the crate 2. move certification header code from `http.rs` to the crate 3. refactor the crate a bit to make the public interface nicer 4. use the crate in the other canisters
przydatek
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
LGTM for the code, but maybe add some documentation to the pub-functionality of the new crate (incl. links to v1 and v2 certification). But if you plan the documentation as step #3 that you've outlined in the PR description, then this PR LGTM as-is.
Yes, I'll add that then, because the interface is going to change bit anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves code to create the certificate headers from
http.rsinto the newasset_utilcrate.This PR is step 2 of 4:
assets.rsto the cratehttp.rsto the crate