Move asset certification code into a new separate crate #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the asset certification code to a new crate, later to be reused by all asset serving canisters in this repository. This PR intentionally only _moves_ code (with the only exception of switching out the implementation for the representation independent hash). There will be a subsequent PR to make the library interface nicer. The code was only moved from `assets.rs` with the exception of the `ContentType` impl. The functionality for certification headers that currently resides in `http.rs` will be added to the crate in later PR as well.
nmattia
reviewed
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the asset certification code to a new crate, later to be reused by all asset serving canisters in this repository.
This PR intentionally only moves code (with the only exception of switching out the implementation for the representation independent hash). There will be a subsequent PR to make the library interface nicer.
The code was only moved from
assets.rswith the exception of theContentTypeimpl. The functionality for certification headers thatcurrently resides in
http.rswill be added to the crate in later PR as well.This PR is step 1 of 4:
assets.rsto the cratehttp.rsto the crate