Add issuer app #2083
Merged
Add issuer app #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an app for the issuer canister, that allows authenticating & adding the authenticated user as an employee. This includes a couple changes: * The issuer canister is updated to allow serving assets. Most of the code for asset serving is copied from `test-app` and II itself. This code will ideally be extracted and replaced with an asset serving library at some point. Includes a fix for certification by @frederikrothenberger. Thanks! * An `app/` directory is added to the issuer. This is a simple React app with a button to authenticate and a button to add the authenticated user as an employee. The vite plugins are copied from the top-level app, and will need to be deduplicated at some point. However for now we keep the app independent from the rest of the II codebase. * An e2e test is added to show how to use the issuer app.
nmattia
requested review from
peterpeterparker,
frederikrothenberger and
przydatek
frederikrothenberger
approved these changes
Nov 28, 2023
nmattia
force-pushed
the
nm-issue-app
branch
3 times, most recently
from
eac1d09 to
259c443
Compare
nmattia
force-pushed
the
nm-issue-app
branch
from
69f97fb to
55a02c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an app for the issuer canister, that allows authenticating & adding the authenticated user as an employee.
This includes a couple changes:
test-appand II itself. This code will ideally be extracted and replaced with an asset serving library at some point. Includes a fix for certification by @frederikrothenberger. Thanks!app/directory is added to the issuer. This is a simple React app with a button to authenticate and a button to add the authenticated user as an employee. The vite plugins are copied from the top-level app, and will need to be deduplicated at some point. However for now we keep the app independent from the rest of the II codebase.🟡 Some screens were changed