-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add second consent message language and make message more descriptive #2073
Conversation
This PR improves the consent messages to be available in 2 languages. The message is improved to be more human readable and is now formatted as markdown. Additionally, the ICRC21 types were updated to reflect the recent spec changes.
Does that mean the frontend should render the message as markdown formatted? |
Yes, ICRC-21 specifies markdown formatting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions but LGTM nonetheless!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @frederikrothenberger!
Please see some suggestions/remarks as discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the updates @frederikrothenberger!
I have one more question, and one minor suggestion, PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR improves the consent messages to be available in 2 languages. The message is improved to be more human readable and is now formatted as markdown.
Additionally, the ICRC21 types were updated to reflect the recent spec changes. Adjusting to the actual types with came case will be done in a separate PR because the issuer API needs adjustment too.