Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor credential spec verification in issuer #2069

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

frederikrothenberger
Copy link
Contributor

@frederikrothenberger frederikrothenberger commented Nov 22, 2023

Introduces an enum to distill down the information in the credential spec to actually supported credentials. This gets rid of unnecessary match arms and is also done in preparation for the consent message rework.


🟡 Some screens were changed

Introduces an enum to distill down the information in the credential
spec to actually supported credentials. This gets rid of unnecessary
match arms and is also done in preparation for the consent message
rework.
Copy link
Collaborator

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit 05b1f99 Nov 23, 2023
53 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/refactor-credential-spec-verify branch November 23, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants