Improve canister network setup #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the way we spin up canisters in a couple of ways: * The `dfx.json` file is made actually useful by creating & deploying all the test canisters * By default II is deploy (through dfx.json) using the test options (fetching the root key & using the dummy captcha). Note: as far as I can tell the `dfx.json` isn't used to deploy anything to mainnet. * The chrome options default to something useful locally (no headless) * The HACKING instructions are updated & simplified This creates a more sane setup where all canisters are deployed in `.dfx`, with simpler commands.
frederikrothenberger
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the way we spin up canisters in a couple of ways:
dfx.jsonfile is made actually useful by creating & deploying all the test canistersdfx.jsonisn't used to deploy anything to mainnet.This creates a more sane setup where all canisters are deployed in
.dfx, with simpler commands.