Remove redundant values in SignedIdAlias #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SignedIdAlias` contained the plain `id_dapp` and `id_alias` values next to the signed JWS. This is redundant and a potential footgun as one might be inclined to use those values _without_ checking the JWS. This PR removes the values and changes the code and doc accordingly.
|
Still in draft because I am waiting for CI to test the issuer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SignedIdAliascontained the plainid_dappandid_aliasvalues next to the signed JWS. This is redundant and a potential footgun as one might be inclined to use those values without checking the JWS.This PR removes the values and changes the code and doc accordingly.
🟡 Some screens were changed