Clean up PIN identity validation #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up a few things related to verifying whether some PIN identity material is still valid (i.e. if the corresponding authenticator/passkey still exists): * The validation is untangled from the IDB lookup * A loader is shown during the API call retrieving the existing authenticators/passkeys * A comment is added about why we don't actually remove the IDB material, even if no corresponding authenticator seems to exist.
frederikrothenberger
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a few things related to verifying whether some PIN identity material is still valid (i.e. if the corresponding authenticator/passkey still exists):
🟡 Some screens were changed