Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

fix: ic0.call_perform spec #348

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: ic0.call_perform spec #348

merged 1 commit into from
Oct 22, 2024

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Oct 17, 2024 •
edited
Loading

This PR fixes issues in ic0.call_perform spec:

  • adds one more condition under which a call successfully finalized by ic0.call_perform might still fail;
  • specifies that discarding a pending call does not refund the prepayment for execution since this prepayment is not charged for a pending call.

@mraszyk mraszyk requested a review from a team as a code owner October 17, 2024 10:32
Dfinity-Bjoern
Dfinity-Bjoern approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@Dfinity-Bjoern Dfinity-Bjoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@mraszyk mraszyk merged commit bed36d9 into master Oct 22, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dfinity-Bjoern Dfinity-Bjoern Dfinity-Bjoern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraszyk @Dfinity-Bjoern