This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
add new transition rejecting stop_canister calls #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bogwar
reviewed
Sep 28, 2023
Co-authored-by: bogwar <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
oggy-dfin
reviewed
Oct 3, 2023
This comment was marked as outdated.
This comment was marked as outdated.
mraszyk
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Dfinity-Bjoern
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
We discussed that it probably makes sense to:
- keep the canister
stopping(my worry about inconsistency was unjustified, rejected calls can change state also elsewhere) - return a
CANISTER_REJECTinstead of aCANISTER_ERROR, since the operation actually changed the state.
crusso
reviewed
Oct 10, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Claudio Russo <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ielashi
reviewed
Nov 8, 2023
mraszyk
commented
Nov 23, 2023
pull bot
pushed a commit
to mikeyhodl/ic
that referenced
this pull request
Nov 24, 2023
feat: Time out stop_canister requests Stop canister requests now time out after 5 minutes. See dfinity/interface-spec#229 for more details. See merge request dfinity-lab/public/ic!15068
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that every canister on the IC mainnet is also charged for its message memory usage which is a scarce resource, it is prudent that calls are not long-running. Hence, this PR introduces the possibility to reject
stop_canistercalls at any time.It also updates the reject code for pending
stop_canistercalls after callingstart_canisterfromCANISTER_REJECT(4) toCANISTER_ERROR(5). This makes sense becauseCANISTER_REJECT(4) is characterized as an "explicit reject by the canister".