This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Initial spec changes for query stats feature #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ic-interface-spec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Dfinity-skaestle
commented
Jul 4, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
mraszyk
reviewed
Oct 11, 2023
This comment was marked as resolved.
This comment was marked as resolved.
lwshang
reviewed
Oct 12, 2023
Dfinity-Bjoern
approved these changes
Oct 24, 2023
|
Dear @Dfinity-skaestle, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA. If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged. — The DFINITY Foundation |
mraszyk
reviewed
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to learn about the performance of canister code, developers would like to gain insights into the size of query call payloads and instructions executed by query calls.
The "query stats" features adds the mechanisms to collect per-node query statistics, aggregate them deterministically and save the instruction counts in the replicated state.
Query stats will be made available to canister developers by means of the canister status API.
Jira
Design doc