chore(IDX): create minimal image #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
reviewed
Jul 31, 2024
Yeah I'm open to suggestions, but essentially it needs to be in a public repo. I wanted to put it in the k8s repo but because that's private it can't create a public image. It's a limitation of GHCR. At the very least, I can add a README to explain that. 👍 |
basvandijk
approved these changes
Jul 31, 2024
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
This PR introduces a minimal runner images that can be used across all dfinity orgs. The reason for this is that self-hosted runners must use a container image, but using `build-ic` for all jobs not in the ic repo is impractical. Because the image is public it can be used in other orgs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a minimal runner images that can be used across all dfinity orgs. The reason for this is that self-hosted runners must use a container image, but using
build-icfor all jobs not in the ic repo is impractical. Because the image is public it can be used in other orgs as well.