Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add wasm_memory_threshold to ProposeToUpdateCanisterSettingsCmd #2864

Merged
merged 26 commits into from
Dec 18, 2024
Merged

feat: Add wasm_memory_threshold to ProposeToUpdateCanisterSettingsCmd #2864

merged 26 commits into from
Dec 18, 2024

Conversation

dragoljub-duric
Copy link
Contributor

@dragoljub-duric dragoljub-duric commented Nov 27, 2024 •
edited by aterga
Loading

To support on_low_wasm_memory hook we are adding wasm_memory_threshold to NNS so it allows users to update its value using NNS proposal. We are as well adding wasm_memory_threshold to canister settings to canisters in IC repo.

The wasm_memory_threshold will be added to the interface specification in dfinity/portal#3761

@dragoljub-duric dragoljub-duric requested a review from a team as a code owner November 27, 2024 16:31
@github-actions github-actions bot added the feat label Nov 27, 2024
@dragoljub-duric dragoljub-duric requested a review from a team as a code owner December 2, 2024 14:40
@dragoljub-duric dragoljub-duric requested review from a team as code owners December 3, 2024 17:12
@dragoljub-duric
Copy link
Contributor Author

@dfinity/nns-team Can someone please help me, I cannot find why test //rs/nervous_system/integration_tests:integration_tests_test_tests/sns_release_qualification is failing?

@anchpop
Copy link
Contributor

anchpop commented Dec 17, 2024 •
edited
Loading

@dfinity/nns-team Can someone please help me, I cannot find why test //rs/nervous_system/integration_tests:integration_tests_test_tests/sns_release_qualification is failing?

I've pushed two commits, and it should pass now. It seems like some other integration tests still need some slight changes though

@dragoljub-duric dragoljub-duric added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit 4c775db Dec 18, 2024
25 checks passed
@dragoljub-duric dragoljub-duric deleted the EXC-1810-add-wasm-memory-threshold-to-propose-to-update-canister-settings-cmd branch December 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregorydemay gregorydemay gregorydemay approved these changes

@mraszyk mraszyk mraszyk left review comments

@aterga aterga aterga approved these changes

@berestovskyy berestovskyy berestovskyy approved these changes

Assignees
No one assigned
Labels
@cross-chain-team @execution feat @pocket-ic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dragoljub-duric @anchpop @aterga @berestovskyy @mraszyk @gregorydemay