Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IDX): bump bazel to 7.4.1 #2686

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat(IDX): bump bazel to 7.4.1 #2686

merged 2 commits into from
Nov 19, 2024

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Nov 19, 2024

This allows us to use string_keyed_label_dicts, which make the usage of environment dependencies easier to follow in system test rules.

@github-actions github-actions bot added the feat label Nov 19, 2024
@nmattia nmattia changed the title feat(IDX): bump to bazel 7.4.1 feat(IDX): bump bazel to 7.4.1 Nov 19, 2024
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/11914526232

New container image: sha256:3c94e87daabcd93fe5d04b0d5e992aac25f77a6f8d8b353f4f861a60a48763b9
New container tag: e0e7f2ed1904fe8db70bb4445971e96055e14e93c757079bbf2b1ec69a4e554a

This allows us to use
[`string_keyed_label_dict`s](https://bazel.build/rules/lib/toplevel/attr#string_keyed_label_dict),
which make the usage of environment dependencies easier to follow
in system test rules.
rs/tests/system_tests.bzl Outdated Show resolved Hide resolved
@nmattia nmattia marked this pull request as ready for review November 19, 2024 16:02
@nmattia nmattia requested review from a team as code owners November 19, 2024 16:02
Copy link
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to finally have string_keyed_label_dicts!

@nmattia nmattia added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit b1a8630 Nov 19, 2024
32 checks passed
@nmattia nmattia deleted the nm-bazel-bump branch November 19, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants