feat: icrc map token metadata to record #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
size-limit report 📦
|
Signed-off-by: David Dal Busco <[email protected]>
AntonioVentilii
approved these changes
Dec 23, 2024
This was referenced Dec 23, 2024
peterpeterparker
added a commit
to dfinity/oisy-wallet
that referenced
this pull request
Dec 23, 2024
# Motivation The `@dfinity/ledger-icrc` now implements a function `mapTokenMetadata` which is equals to our `mapOptionalToken` function (it was copied from there, see PR [#798](dfinity/ic-js#798)), therefore we can use this utility. # Notes Maybe I should have marked the type of the function as generic in ic-js since we basically duplicates the same type with zod but TypeScript is able to understand both types are equals it seems. # Changes - Replace function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I've been implementing the same mapper repeatedly, and today I needed it in another library (the oisy-wallet-signer). Instead of reimplementing it again, I added a utility to the ledger-icrc library to map the token metadata information from a ledger response provided in form of Candid arrays into a structured record.
Changes
mapTokenMetadata.