New voting power related fields in NeuronInfo #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mstrasinskis
changed the title
mstrasinskis
changed the title
Good point @dskloetd, the absence of toNeuronInfo tests is not an excuse for not writing them. I’ve added the tests now. |
dskloetd
approved these changes
Dec 19, 2024
1 task
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Dec 19, 2024
# Motivation To access the [new fields](dfinity/ic-js#794) of the neuron info, we need to upgrade the ic-js version. # Changes - `npm run upgrade:next` # Tests - Added new fields to the mock NeuronInfo. - Pass. # Todos - [ ] Add entry to changelog (if necessary). Not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After introducing new neuron properties (
deciding_voting_powerandpotential_voting_power), the originalvoting_powerfield has become obsolete. With this PR, we add three new fields to the NeuronInfo:decidingVotingPower,potentialVotingPower, and a small drive-by additionvotingPowerRefreshedTimestampSeconds; and mark the original votingPower field as deprecated.Changes
votingPoweras deprecated.Tests
Todos
Not necessary.