Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose snapshot types #777

Merged
merged 4 commits into from
Dec 4, 2024
Merged

feat: expose snapshot types #777

merged 4 commits into from
Dec 4, 2024

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Nov 28, 2024

Motivation

I found few did snapshots types that weren't exposed. I actually ultimatelly did not required those in my implementation but, it's cleaner anyway to expose those.

Changes

  • Expose few types for ic-mgmt in index.ts

Signed-off-by: David Dal Busco <[email protected]>
Copy link
Contributor

github-actions bot commented Nov 28, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 8.02 KB (0%)
@dfinity/cketh 3.68 KB (0%)
@dfinity/cmc 1.4 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.74 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 16.96 KB (0%)
@dfinity/utils 4.66 KB (0%)
@dfinity/ic-management 3.19 KB (0%)

Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker marked this pull request as ready for review November 28, 2024 18:00
@peterpeterparker peterpeterparker requested review from a team as code owners November 28, 2024 18:00
@peterpeterparker
Copy link
Member Author

peterpeterparker commented Nov 28, 2024

Actually, I did not required those type because my bundler is friendly 😁

In my PR junobuild/juno-js#220 it works because I resolve the type directly from the did file.

import type {
  take_canister_snapshot_result
} from '@dfinity/ic-management/dist/candid/ic-management';

So no blocker but, it will be nicer.

Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Copy link

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks!

@peterpeterparker peterpeterparker merged commit b15e7f2 into main Dec 4, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/expose-types branch December 4, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants