Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: eslint for tests #770

Merged
merged 1 commit into from
Nov 22, 2024
Merged

chore: eslint for tests #770

merged 1 commit into from
Nov 22, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

TIL our tests suite was not validated with eslint until today.

Notes

I'll allow _ as unused var in #769. Meanwhile I added four eslint ignore in tests in this PR.

Changes

  • Activate eslint for tests with a specific tsconfig.eslint.json that does not exclude the test
  • Fix eslint issue in tests (mostly missing import type and few unused variables)

Screenshots

Capture d’écran 2024-11-21 à 18 09 17 Capture d’écran 2024-11-21 à 18 09 14 Capture d’écran 2024-11-21 à 18 09 10

@peterpeterparker
chore: eslint for tests
30c626c 
Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker requested review from a team as code owners November 21, 2024 17:15
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/ckbtc 8.03 KB (0%)
@dfinity/cketh 3.68 KB (0%)
@dfinity/cmc 1.4 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.68 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 16.78 KB (0%)
@dfinity/utils 4.66 KB (0%)
@dfinity/ic-management 3.19 KB (0%)

AntonioVentilii
AntonioVentilii approved these changes Nov 22, 2024
View reviewed changes
Copy link

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks

@peterpeterparker peterpeterparker merged commit 5b6f8af into main Nov 22, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the chore/estlint-for-test branch November 22, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioVentilii AntonioVentilii AntonioVentilii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @AntonioVentilii