Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete canister snapshot #766

Merged
merged 9 commits into from
Nov 21, 2024
Merged

feat: delete canister snapshot #766

merged 9 commits into from
Nov 21, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

Support for the last feature of snapshot: delete_canister_snapshot

Changes

  • Add deleteCanisterSnapshot to ic-mgmt

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 8.03 KB (0%)
@dfinity/cketh 3.68 KB (0%)
@dfinity/cmc 1.4 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.68 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 16.78 KB (0%)
@dfinity/utils 4.66 KB (0%)
@dfinity/ic-management 3.19 KB (+0.53% 🔺)

@peterpeterparker peterpeterparker marked this pull request as ready for review November 21, 2024 11:52
@peterpeterparker peterpeterparker requested review from a team as code owners November 21, 2024 11:52
AntonioVentilii
AntonioVentilii approved these changes Nov 21, 2024
View reviewed changes
Copy link

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks

@peterpeterparker peterpeterparker merged commit 5641321 into main Nov 21, 2024
10 checks passed
@peterpeterparker peterpeterparker deleted the feat/delete-canister-snapshot branch November 21, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioVentilii AntonioVentilii AntonioVentilii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @AntonioVentilii