Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: utils to mapSnapshotId #764

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

peterpeterparker
Copy link
Member

Motivation

As suggested by @AntonioVentilii in #759 (comment) we can create a function to map the snapshot id because we will reuse similar pattern in #763.

Changes

  • Extract mapper in utils
  • Use mapper in existing implementation

Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Copy link
Contributor

github-actions bot commented Nov 21, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 8.03 KB (0%)
@dfinity/cketh 3.68 KB (0%)
@dfinity/cmc 1.4 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.68 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 16.78 KB (0%)
@dfinity/utils 4.66 KB (0%)
@dfinity/ic-management 3.13 KB (+0.19% 🔺)

Copy link

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks!

No CHANGELOG update, correct?

@peterpeterparker
Copy link
Member Author

No CHANGELOG update, correct?

As discussed offline, the existing entry in the CHANGELOG about the snapshot feature is generic.

@peterpeterparker peterpeterparker merged commit 80badcf into main Nov 21, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/mapSnapshotId-utils branch November 21, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants