Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose ic-mgmt types #762

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: expose ic-mgmt types #762

merged 2 commits into from
Nov 21, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

Few DID types should probably be exposed as they are part of the response but defined by Candid.

Changes

  • Expose few types in index.ts of ic-mgmt

@peterpeterparker
feat: expose ic-mgmt types
f5b8426 
Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker
feat: expose ic-mgmt types
0408a1b 
Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker requested review from a team as code owners November 21, 2024 06:07
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/ckbtc 8.03 KB (0%)
@dfinity/cketh 3.68 KB (0%)
@dfinity/cmc 1.4 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.68 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 16.78 KB (0%)
@dfinity/utils 4.66 KB (0%)
@dfinity/ic-management 3.12 KB (0%)

@peterpeterparker peterpeterparker merged commit a22db87 into main Nov 21, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/missing-type branch November 21, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

@AntonioVentilii AntonioVentilii Awaiting requested review from AntonioVentilii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @dskloetd