Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove @types/node #753

Merged
merged 2 commits into from
Nov 20, 2024
Merged

build: remove @types/node #753

merged 2 commits into from
Nov 20, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

It seems we actually do not need the dev dependency @types/node.

Changes

  • npm rm @types/node

Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker requested review from a team as code owners November 19, 2024 20:05
Copy link
Contributor

github-actions bot commented Nov 19, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 8.03 KB (0%)
@dfinity/cketh 3.68 KB (0%)
@dfinity/cmc 1.4 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.68 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 16.78 KB (0%)
@dfinity/utils 4.64 KB (0%)
@dfinity/ic-management 3.02 KB (0%)

Copy link
Collaborator

@dskloetd dskloetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit 996f06e into main Nov 20, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the chore/remove-type-node branch November 20, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants