Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update ckETH minter withdrawals with subaccounts #751

Merged
merged 6 commits into from
Nov 19, 2024
Merged

feat: update ckETH minter withdrawals with subaccounts #751

merged 6 commits into from
Nov 19, 2024

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Nov 18, 2024 •
edited
Loading

Motivation

The ckETH minter withdrawl functions have been extended with optional subaccounts.

Changes

  • Update DID files as generated by Update Candid Files #750 (did were stripped from the PR to create this PR).
  • Add subaccount options to ckEth minter withdrawl features.

@peterpeterparker
feat: update ckETH minter
820bc2e 
Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker mentioned this pull request Nov 18, 2024
Closed
1 task
@peterpeterparker
feat: from subacount parameters
07fcad3 
Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker marked this pull request as ready for review November 18, 2024 15:48
@peterpeterparker peterpeterparker requested review from a team as code owners November 18, 2024 15:48
@peterpeterparker peterpeterparker changed the title feat: update ckETH minter feat: update ckETH minter withdrawals with subaccounts Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 8.02 KB (0%)
@dfinity/cketh 3.68 KB (+1.76% 🔺)
@dfinity/cmc 1.4 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.68 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 16.67 KB (0%)
@dfinity/utils 4.64 KB (0%)
@dfinity/ic-management 3.02 KB (0%)

dskloetd
dskloetd approved these changes Nov 19, 2024
View reviewed changes
packages/cketh/src/minter.canister.spec.ts Outdated Show resolved Hide resolved
@peterpeterparker peterpeterparker merged commit 2353883 into main Nov 19, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/update-cketh-minter branch November 19, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @dskloetd